Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: watsonx support #4094

Closed
wants to merge 3 commits into from
Closed

feat: watsonx support #4094

wants to merge 3 commits into from

Conversation

tsinggggg
Copy link
Contributor

Why are these changes needed?

To enhance the support of non-OpenAI models with AutoGen, adding watsonx.ai into the mix to support both IBM granite series of models and others non-IBM models hosted in watsonx.ai

Related issue number

Checks

@tsinggggg
Copy link
Contributor Author

@microsoft-github-policy-service agree

@tsinggggg
Copy link
Contributor Author

Hi @Hk669 , would you please review this PR? I saw you review the latest addition of non-oai client bedrock. I am happy to follow up with a PR towards the main branch later as well. Thank you!

@ekzhu
Copy link
Collaborator

ekzhu commented Nov 10, 2024

@tsinggggg thank you for your contribution!

Given we are close to release of v0.4 version. Would you like to create a community package for Wasonx client following the v0.4 ChatCompletionClient protocol? You can find existing implementations here: https://github.com/microsoft/autogen/tree/main/python/packages/autogen-ext/src/autogen_ext/models.

For guidance on how to create a community package: https://microsoft.github.io/autogen/dev/user-guide/extensions-user-guide/index.html

Once you create one you can submit a PR to our documentation so we can index it.

The reason we ask for community package is because it is not feasible for us to maintain clients to APIs that we don't have access to.

@tsinggggg
Copy link
Contributor Author

Hi @ekzhu , thanks a lot for the suggestions!

I created an extension for using watsonx with autogen 0.4. I released it to pypi here https://pypi.org/project/autogen-watsonx-client/

This is the PR #4130 for the doc update in the main branch if you would review. Thank you!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.60927% with 138 lines in your changes missing coverage. Please review.

Project coverage is 29.05%. Comparing base (8a8fcd8) to head (a966cae).
Report is 3 commits behind head on 0.2.

Files with missing lines Patch % Lines
autogen/oai/watsonx.py 6.42% 131 Missing ⚠️
autogen/oai/client.py 40.00% 5 Missing and 1 partial ⚠️
autogen/runtime_logging.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              0.2    #4094      +/-   ##
==========================================
- Coverage   29.30%   29.05%   -0.25%     
==========================================
  Files         117      118       +1     
  Lines       13013    13168     +155     
  Branches     2469     2496      +27     
==========================================
+ Hits         3813     3826      +13     
- Misses       8854     8995     +141     
- Partials      346      347       +1     
Flag Coverage Δ
unittests 29.05% <8.60%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MohMaz
Copy link
Contributor

MohMaz commented Nov 27, 2024

@tsinggggg seems CI is failing, marking this as awaiting-op-response.

@MohMaz MohMaz added the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Nov 27, 2024
@tsinggggg tsinggggg closed this Nov 27, 2024
@tsinggggg
Copy link
Contributor Author

closing as #4130 has been merged to 0.4 version

@github-actions github-actions bot removed the awaiting-op-response Issue or pr has been triaged or responded to and is now awaiting a reply from the original poster label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants