Skip to content

Commit

Permalink
Bugfix: Web surfer creating incomplete copy of messages (#4050)
Browse files Browse the repository at this point in the history
* bugfix: create full copy of history (including last message)

* websurfer: copy entire message context only when last message is tool message
  • Loading branch information
Hedrekao authored Nov 25, 2024
1 parent 2d52bbc commit 758edb7
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions autogen/agentchat/contrib/web_surfer.py
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ def _page_down() -> str:
def _find_on_page_ctrl_f(
search_string: Annotated[
str, "The string to search for on the page. This search string supports wildcards like '*'"
]
],
) -> str:
find_result = self.browser.find_on_page(search_string)
header, content = _browser_state()
Expand Down Expand Up @@ -344,7 +344,17 @@ def generate_surfer_reply(

# Clone the messages to give context
self._assistant.chat_messages[self._user_proxy] = list()
history = messages[0 : len(messages) - 1]

# If the last message is a tool message it has to be included in context,
# otherwise openAI will throw exception that not all tool calls are followed by corresponding tool messages
# In a case where the last message is not a tool message, we fallback to default behavior in the library
# which is copying all messages except the last one
# Issue is described more thoroughly in PR https://github.com/microsoft/autogen/pull/4050
if messages[-1].get("role", "assistant") == "tool":
history = messages[:]
else:
history = messages[0 : len(messages) - 1]

for message in history:
self._assistant.chat_messages[self._user_proxy].append(message)

Expand Down

0 comments on commit 758edb7

Please sign in to comment.