Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented -[NSConditionLock lockWhenCondition:beforeDate:] #2508

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Implemented -[NSConditionLock lockWhenCondition:beforeDate:] #2508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 42 additions & 3 deletions Frameworks/Foundation/NSConditionLock.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,11 +148,50 @@ - (void)lockWhenCondition:(NSInteger)condition {
}

/**
@Status Stub
@Status Interoperable
*/
- (BOOL)lockWhenCondition:(NSInteger)condition beforeDate:(NSDate*)date {
UNIMPLEMENTED();
return NO;
int rc;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume rc is for "return code"? Please don't choose single letter / abbreviated variable names as it is unclear to future readers what the abbreviation / implicit word is. Perhaps statusCode / returnCode, etc here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DHowett-MSFT I didn't see the surrounding context sorry. Probably ok then.

struct timespec t = { 0 };
struct EbrTimeval tv;
NSTimeInterval d = [date timeIntervalSinceNow];

EbrGetTimeOfDay(&tv);

t.tv_sec = tv.tv_sec;
t.tv_nsec = tv.tv_usec * 1000;

t.tv_sec += (unsigned int)d;
t.tv_nsec = (long)((double)t.tv_nsec + fmod(d, 1.0) * 1000000000.0);

t.tv_sec += t.tv_nsec / 1000000000;
t.tv_nsec %= 1000000000;

if ((rc = pthread_mutex_lock(&_mutex)) != 0) {
[NSException raise:NSInvalidArgumentException format:@"failed to lock %@ (errno: %d)", self, rc];
}

while (_value != condition) {
switch ((rc = pthread_cond_timedwait(&_cond, &_mutex, &t))) {
case 0:
break;

case ETIMEDOUT:
if ((rc = pthread_mutex_unlock(&_mutex)) != 0) {
[NSException raise:NSInvalidArgumentException format:@"failed to unlock %@ before date %@ (errno: %d)", self, date, rc];
}
return NO;

default:
if ((rc = pthread_mutex_unlock(&_mutex)) != 0) {
[NSException raise:NSInvalidArgumentException format:@"failed to unlock %@ before date %@ (errno: %d)", self, date, rc];
}
[NSException raise:NSInvalidArgumentException format:@"failed to lock %@ before date %@ (errno: %d)", self, date, rc];
return NO;
}
}

return YES;
}

/**
Expand Down