Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WindowWalker]Added Score to the results returned by WindowWalker #35691

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

andbartol
Copy link
Contributor

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

The score was already calculated by the plugin but was not passed to the launcher's Result.

Validation Steps Performed

I tried to recreate a situation similar to the open issue
Before:
image
After:
image

@andbartol andbartol marked this pull request as ready for review October 31, 2024 12:04
@crutkas
Copy link
Member

crutkas commented Oct 31, 2024

🔥🔥🔥

@htcfreek htcfreek added the Needs-Review This Pull Request awaits the review of a maintainer. label Nov 13, 2024
Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution! Definitely an oversight that wasn't already there.

@jaimecbernardo jaimecbernardo merged commit a90b646 into microsoft:main Nov 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in for .87 Needs-Review This Pull Request awaits the review of a maintainer.
Projects
Development

Successfully merging this pull request may close these issues.

4 participants