Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspaces] implement the move feature #35480

Open
wants to merge 43 commits into
base: main
Choose a base branch
from

Conversation

donlaci
Copy link
Collaborator

@donlaci donlaci commented Oct 18, 2024

Summary of the Pull Request

Adding possibility to move existing windows instead of launching new instances.

PR Checklist

Detailed Description of the Pull Request / Additional comments

Validation Steps Performed

This comment has been minimized.

@SeraphimaZykova
Copy link
Collaborator

I tested the latest update, and those scenarios work as expected:

  • Move already opened windows
  • Launch windows that are not opened.
  • If there are several windows opened, move the closest window of the app
  • Minimize apps
  • Restore minimized apps
  • Move opened windows in a single-monitor environment
  • Move opened windows in a multi-monitor environment

But there are still some scenarios that need to be fixed.

  1. Move existing windows setting is reset after clicking Launch and edit and capturing.
  2. Browsers and PWA apps. Here are the steps to reproduce the broken scenario:
    • Create a workspace with a PWA app and a browser (the same browser as for PWA).
    • Close the PWA app.
    • Minimize browser window.
    • Launch the workspace. As a result, I have a new browser window opened instead of the PWA app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants