Support trailing slashes in paths

[mderriey]

fixes #1580

This is a very naïve attempt at supporting trailing slashes in paths.

Please let me know if there are other cases that would need to be covered by the tests, or if this implementation would break in specific scenarios.

[baywet]

Thanks for the contributions, a couple of recommendations.

[baywet]

thank you for making the update, I think we're getting closer to a solution here. Left a couple of comments

[baywet]

Suggested change

	{ "/cars/{car-id}/build/", ["cars", "{car-id}"], "build/", @"\cars\{car-id}\build/" },
	{ "/cars/", [], "cars/", @"\cars/" },
	{ "/cars/{car-id}/build/", ["cars", "{car-id}"], @"build\", @"\cars\{car-id}\build\" },
	{ "/cars/", [], "cars/", @"\cars\" },

wouldn't this make more sense?

[mderriey]

That's for you to say.

My interpretation was that \ was used as as a hierarchy separator, and given the last / is not a separator per-se, we might want to keep it as-is to indicate that the last segment is <whatever>/.

If you want the changes in, though, that's fine, I'll push them.

[baywet]

as long as it doesn't derail the logic/node structure, it'd make sense to be consistent.
@darrelmiller I can't remember why backslashes were originally used here instead of forward slashes, would you mind providing some context please?

[darrelmiller]

I can't find out why we used backslash as a separator. It doesn't make sense to me. I tried looking at all the relevant PRs. Maybe @irvinesunday remembers?

[irvinesunday]

I haven't used backslash anywhere as a separator within this codebase 🤔

[baywet]

alright, thanks for your patience with us @mderriey it seems we suffer from collective amnesia.
In the interest of unblocking this PR, and reducing potential side effects, let's perform the least changes possible, and align everything on backslashes.

[baywet]

Suggested change

	segments[segments.Length - 1] += "/";
	segments[segments.Length - 1] += @"\";