[Bug]Fix init issue for rms_norm in sequence_parallel. #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ys950902
requested review from
tjruwase,
awan-10,
eltonzheng,
duli2012,
arashb and
GuanhuaWang
as code owners
polisettyvarma
approved these changes
Sep 24, 2024
tjruwase
reviewed
Sep 24, 2024
tjruwase
approved these changes
Sep 25, 2024
polisettyvarma
approved these changes
Sep 25, 2024
|
Hi @tjruwase, many thanks for your approve, could you please also help to merge it. |
polisettyvarma
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using rmsnorm will get the error below:
[rank0]: self.input_layernorm = RMSNorm(config.hidden_size, config.layernorm_epsilon,
[rank0]: TypeError: RMSNorm.init() got an unexpected keyword argument 'sequence_parallel'
This pr is to fix this init issue.