Improve Update-Engines.ps1 to not download the same file again #2212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="AOK-Bundesverband eGbR" |
lusassl-msft
added
Enhancement
dpaulson45
reviewed
Oct 25, 2024
| @@ -241,22 +241,27 @@ foreach ($p in $Platforms) { | |||
| $fullPkgUrl = $engineUrl + $manifest.ManifestFile.Package.version + "/" + $manifest.ManifestFile.Package.FullPackage.name | |||
| $fullPkgPath = ($fullPkgDir + $manifest.ManifestFile.Package.FullPackage.name) | |||
|
|
|||
| $wc.DownloadFile($fullPkgUrl, $fullPkgPath) | |||
| if (((Test-Path $fullPkgPath) -ne $true) -or ((Get-Item $fullPkgPath).Length -ne $manifest.ManifestFile.Package.FullPackage.Size)) { | |||
There was a problem hiding this comment.
Is the $fullPkgPath always going to be different for each version?
There was a problem hiding this comment.
todo: add some cleanup logic to the script...
|
Pending test team to confirm we can merge this one. |
lusassl-msft
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Download of a new signature file takes >15minutes so Exchange isn't able to download the files in our network. -> timeout
When Update-Engines.ps1 is run by a scheduled task every 15min it will re-download the current file and overwrite the existing. While the download is in progress the file cannot be used by Exchange and signature Update will fail.
Fix:
do not download the file again when it already exists and has the correct size
Resolved #2108