Hybrid Free Busy Configuration Checker #1934
Conversation
|
@MarcoLFrancisco do you still work on this PR? Please re-request a review once this is ready to be reviewed. Thanks. |
|
@MarcoLFrancisco do you still want to work on this PR? Otherwise, we will close this out. |
|
Closing out as no updates since March. |
|
Good morning, my appologies but I missed last comments. Can the pull request be reactivated? |
|
Reopened as requested by @MarcoLFrancisco |
|
Good morning, I will start to address the last recomendations this weekend. I believe i can probably finish them during the weekend, if not they should all be addressed no latter than the following weekend. |
|
All changes are now implemented. I need a few more days for testing to confirm all functions are working and html output is correctly formated
|
|
Please comment on here once you are ready for us to review the script again. |
Pushing requested changes
| $LogFileName = [System.IO.Path]::GetFileNameWithoutExtension($LogFile) + "_" + $Script:startingDate + ([System.IO.Path]::GetExtension($Script:LogFile)) | ||
| Write-Host " `n`n " | ||
| Write-Host " `n`n " | ||
| Start-Transcript -Path $LogFileName -Append |
There was a problem hiding this comment.
Since you only appear to have Write-Host in the script this works. However, it makes the end user text file rather wordy. A better option is to only display the needed information, and then for diagnostic purposes, like script troubleshooting, have that information in Write-Verbose which is not captured in Start-Transcript unless they provide -Verbose.
We do have logging functions already created in the share, but this isn't required at this time.
There was a problem hiding this comment.
Removed both Write-Host " nn "
There was a problem hiding this comment.
This was in regard to using Start-Transcript
|
Due to a code formatting rule change, you will need to run that locally and address the issues seen there. |
|
@MarcoLFrancisco please review the PR and make the required adjustments. |
|
Good evening. Due to the recent security changes regarding Hybrid Test Envoyronments I am rebuilding my lab setup. This is delaying development and testing. I should be able to finish my lab setup at the end of this week and resolve the above mentioned issues. Appologies for the delay. |
|
Good evening, Pushed version with requested changes. Code Fromater and Spell Checker reports no errors. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I believe issue is now fixed. |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mkdocs.yml
Outdated
| @@ -75,7 +75,7 @@ nav: | |||
| - TransportRetryConfigCheck: Diagnostics/HealthChecker/TransportRetryConfigCheck.md | |||
| - ManagedAvailabilityTroubleshooter: Diagnostics/ManagedAvailabilityTroubleshooter.md | |||
| - Test-ExchAVExclusions: Diagnostics/Test-ExchAVExclusions.md | |||
| - FreeBusyChecker: Diagnostics/FreeBusyChecker/FreeBusyChecker.md | |||
| - FreeBusyChecker: Diagnostics/FreeBusyChecker.md | |||
There was a problem hiding this comment.
Yes, my mistake. Updated and pushed.
There was a problem hiding this comment.
Its pushed, but I'm unsure if I should use this sintax:
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Correcting this formating issues
|
|
Changes corrected and pushed |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Okay, so this passed now we need to squash this down to a single commit and then we should be able to merge and release this. |
Issue:
Collect Exchange Hybrid Free Configuration Information in Exchange deployments is often time consuming and a big effort
Reason:
This script is aimed to assist in collecting Hybrid Free busy configuration information, both for OAuth and DAuth and both from On Premise and Exchange online side. It provides also information for what would be expected for each component reviewed and can assist our customer and our support engineers.
Fix:
Script collects relevant information as described in Microsoft Internal Documentation. Script does not produce changes on customer side other than generating txt and html Output
Validation:
Utilized on several occasions both on lab environments and with active support cases. It has proven to be useful.