Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable LTO and update changelog #6777

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Disable LTO and update changelog #6777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c4cb98
Disable LTO and update changelog
achamayou Jan 24, 2025
d30c7e6
Merge branch 'main' into disable_lto
achamayou Jan 24, 2025
9ae2f2f
Merge branch 'main' into disable_lto
achamayou Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@ and this project adheres Fto [Semantic Versioning](http://semver.org/spec/v2.0.0

- Joining nodes can now request a snapshot from their peers at startup, rather than relying on file access. The joinee's snapshot will be fetched and used if it is more recent than the joiner has access to. This behaviour is enabled by default, but can be disabled via the `command.join.fetch_recent_snapshot` config option (#6758).

### Changed

- CCF now defaults to using libstdc++ rather than libc++, and no longer builds with LTO, to improve compatibility with other C++ libraries.

## [6.0.0-dev12]

[6.0.0-dev12]: https://github.com/microsoft/CCF/releases/tag/6.0.0-dev12
Expand Down
9 changes: 0 additions & 9 deletions cmake/preproject.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,13 +82,4 @@ if("${COMPILE_TARGET}" STREQUAL "snp")
endif()
endif()

if("${COMPILE_TARGET}" STREQUAL "snp" OR "${COMPILE_TARGET}" STREQUAL "virtual")
if(NOT "${CMAKE_BUILD_TYPE}" STREQUAL "Debug" AND NOT TSAN)
add_compile_options(-flto)
endif()
# Unconditionally make linker aware of possible LTO happening. Otherwise
# targets built in Debug and linked against this will fail linkage.
add_link_options(-flto)
endif()

set(CMAKE_CXX_STANDARD 20)
Loading