Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid request to be blocked once the "dispose" method has been called #1196

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

Apokalypt
Copy link

When the dispose method is called, the static INSTANCE property is set to null, which means there is no query handler (neither the original nor the custom handler).
So I've added a control to call the default handler if the INSTANCE property is set to null

Fix #1195

Copy link
Member

@hectorhdzg hectorhdzg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@hectorhdzg hectorhdzg merged commit aaafbfd into microsoft:develop Sep 6, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Calling the global "dispose" method prevents the express server from running
2 participants