-
Notifications
You must be signed in to change notification settings - Fork 553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Spec] Plan for updating the FactSet element #7509
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If FactSet's title and value have all of the properties of TextBlock, we can also use TextBlocks as values of FactSet's title and value.
With this change, I'm wondering what benefits cards authors get when they can use Tables with TextBlocks.
I think factset cover only the scenario where you want a 2 by N table |
Yes, you are correct. I like the changes. My humble suggestion is we can also consider factoring out text properties and create a new property that holds all of the text properties as we do with Background Property. |
I think this is done in code in the shared model for TextBlock and TextRuns, do you want to open that paradigm to the format of the card? |
Hi @almedina-ms. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along. |
Related Issue
Proposal for a long lasting fix for https://microsoft.visualstudio.com/OS/_workitems/edit/37990023
Description
Add details of how to update the FactSet element to provide a general better experience for car authors
Microsoft Reviewers: Open in CodeFlow