This repository has been archived by the owner on Jul 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailnikolaev
approved these changes
Nov 8, 2019
msdmkats
force-pushed
the
dmkats/docs
branch
from
November 11, 2019 09:13
4a71f9d
to
c576870
Compare
iliaeg
approved these changes
Nov 11, 2019
ISSUES.md
Outdated
- Manual | ||
- `ba_d.cpp` - refactor functions under `DO_CPP` to work without Eigen | ||
- Perhaps add Hand derivative without Eigen | ||
- GMM produces "NaN" for Jacobians when `d = 64`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I this still true? I thought the logsumexp
patch was to fix that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No it isn't. I edited this file last time before fixing it. Updated.
tomjaguarpaw
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really excellent and comprehensive. A suggestion and a couple of questions above.
msdmkats
force-pushed
the
dmkats/docs
branch
from
November 13, 2019 09:14
2c65101
to
0128704
Compare
msdmkats
force-pushed
the
dmkats/docs
branch
from
November 13, 2019 11:15
e173642
to
7044f5b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dev docs for
User docs for
run-all.ps1
)Updated README and CONTRIBUTING to link to the new docs.
Updated ISSUES and STATUS.
NB: some links in the new docs are currently dead as they point to docs that are in other PRs.