Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute async controller methods without Reactor #10212

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Execute async controller methods without Reactor #10212

merged 2 commits into from
Dec 6, 2023

Conversation

dstepanov
Copy link
Contributor

No description provided.

@dstepanov dstepanov added this to the 4.3.0 milestone Dec 5, 2023
@dstepanov dstepanov added the type: improvement A minor improvement to an existing feature label Dec 5, 2023
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

@dstepanov dstepanov merged commit 4d93f38 into 4.3.x Dec 6, 2023
16 checks passed
@dstepanov dstepanov deleted the asynccon branch December 6, 2023 09:46
yawkat
yawkat approved these changes Dec 6, 2023
View reviewed changes
core/src/main/java/io/micronaut/core/execution/CompletableFutureExecutionFlow.java
@@ -38,8 +38,8 @@ public interface CompletableFutureExecutionFlow<T> extends ExecutionFlow<T> {
* @return a new flow
*/
@NonNull
static <K> ExecutionFlow<K> just(@NonNull CompletableFuture<K> value) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hope this method isn't used outside core because this is a binary incompatible change. it's probably fine because this is Internal but it might be another servlet situation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh right, will see

http-server/src/main/java/io/micronaut/http/server/RouteExecutor.java
private CompletionStage<MutableHttpResponse<?>> fromCompletionStage(@NonNull HttpRequest<?> request,
@NonNull Object body,
@NonNull RouteInfo<?> routeInfo) {
CompletionStage<Object> completionStage = (CompletionStage<Object>) body;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could be null i think

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nulls are handled before

@renovate renovate bot mentioned this pull request May 4, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yawkat yawkat yawkat approved these changes

@graemerocher graemerocher graemerocher approved these changes

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
No open projects
4.3.0 Release
Status: Done
Milestone
4.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dstepanov @graemerocher @yawkat