Skip to content

Commit

Permalink
Fix goaway test (#10079)
Browse files Browse the repository at this point in the history
Seems the test was just broken. The internal error goaway frame made netty close the channel, which may send some bogus TLS and doesn't actually hit the code this test was supposed to test.

Please try on mac.
  • Loading branch information
yawkat authored Nov 8, 2023
1 parent f4e49de commit 67dd2d7
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1034,7 +1034,8 @@ class ConnectionManagerSpec extends Specification {
conn1.exchangeSettings()
conn1.testExchangeResponse(future)

conn1.serverChannel.writeOutbound(new DefaultHttp2GoAwayFrame(Http2Error.INTERNAL_ERROR, Unpooled.copiedBuffer("foo", StandardCharsets.UTF_8)))
// use NO_ERROR so that netty doesn't close the channel
conn1.serverChannel.writeOutbound(new DefaultHttp2GoAwayFrame(Http2Error.NO_ERROR, Unpooled.copiedBuffer("foo", StandardCharsets.UTF_8)))
conn1.advance()

// after goaway, new requests should use a new connection
Expand Down

0 comments on commit 67dd2d7

Please sign in to comment.