Handle radio connect/ reconnect error scenarios #281

microbit-grace · 2024-08-01T11:03:21Z

Task: https://microbit-global.monday.com/boards/1125389526/pulses/1575488964

Expected behaviour: Error connection cases logic https://paper.dropbox.com/doc/Reconnect-scenarios-copy--CTKwX5AyHNMod6Uq0Qosp8ZtAg-RWeX90ac5YQ9erncFZmWN can be used as reference

EDITED
Also implemented bluetooth connection fail dialog since there were conflicting changes
https://microbit-global.monday.com/boards/1125389526/pulses/1576736316

Other minor changes

Includes a small fix in logic in Add Data page so that data can be visible without connecting
For radio connection dev purposes, when locally developing, a skip button is visible for micro:bit 1 and the device Id is stored in the local storage.
Close start over session warning dialog when new session is selected

This mimics the existing behaviour and also means that the radio remote micro:bit does not need to be flashed in order to find the device id so that step can be skipped in development mode

github-actions · 2024-08-01T11:03:35Z

Preview build will be at
https://review-ml.microbit.org/radio-error

Aligning with existing reconnecting design

microbit-grace · 2024-08-01T14:50:09Z

src/components/ConnectCableDialog.tsx

+    ...(stage === "local"
+      ? {
+          linkTextId: "connectMB.connectCable.skip",
+          onLink: LinkType.Skip,
+        }
+      : {
+          onLink: LinkType.None,
+        }),


For radio connection dev purposes, when locally developing, a skip button is visible for micro:bit 1 and the device Id is stored in the local storage.

microbit-grace · 2024-08-01T14:51:18Z

src/pages/AddDataPage.tsx

@@ -44,7 +44,7 @@ const AddDataPage = () => {

  const noStoredData = useMemo<boolean>(() => {
    const gestureData = gestures.data;
-    return (
+    return !(


Small fix in logic in Add Data page so that data can be visible without connecting

microbit-grace · 2024-08-01T14:51:54Z

src/components/StartResumeActions.tsx

@@ -22,13 +22,20 @@ const StartResumeActions = ({ ...props }: Partial<StackProps>) => {
  }, [navigate]);

  const handleStartNewSession = useCallback(() => {
+    startOverWarningDialogDisclosure.onClose();


Small fix: Close start over session warning dialog when new session is selected

microbit-robert · 2024-08-02T09:21:21Z

If you have no recordings and you lose the remote micro:bit connection, you get this screen, which is pretty weird.

The live graph also stops moving while "reconnecting" is shown, and I don't think that is right or matches the current behaviour in the nextgen/prototype version.

microbit-robert · 2024-08-02T09:30:49Z

If you reset the bridge micro:bit, we await the connection timeout, then show a dialog saying that the connection to micro:bit 1 has been lost, which isn't right. In the nextgen/prototype version, the reconnection attempt succeeds.

microbit-robert · 2024-08-02T09:36:53Z

Clicking "disconnect" now causes the following error Error: Bad status for 8 -> 255. This doesn't happen in the connection library demo, so I suspect it might be due to something being triggered here in response to the connection status updating?

EDIT: The Bad status for 8 -> 255 error only happens on my micro:bit v2.00, and it only happens when it's the bridge micro:bit and initially displaying a dot. After the first connection, the first disconnection fails. The device remains in a state where it is displaying a diamond. If you refresh the page and connect while the device is showing a diamond, subsequent disconnects and reconnects work as expected. This behaviour can be replicated in the connection library demo. The error occurs at the first writeMem32 call in the softwareReset method.

It is not clear if this is version or device specific.

EDIT: This has been resolved by adding software reset to the serial state change queue.

microbit-robert

I've skimmed through the code changes so far. I've hit a snag with the disconnect button with the radio bridge noted in a separate comment and can't review all of the potential flows until this has been ammended.

…plicitly or automatically

microbit-grace · 2024-08-02T14:33:00Z

If you have no recordings and you lose the remote micro:bit connection, you get this screen, which is pretty weird.
The live graph also stops moving while "reconnecting" is shown, and I don't think that is right or matches the current behaviour in the nextgen/prototype version.

62f7dbf

microbit-grace · 2024-08-02T16:03:48Z

If you reset the bridge micro:bit, we await the connection timeout, then show a dialog saying that the connection to micro:bit 1 has been lost, which isn't right. In the nextgen/prototype version, the reconnection attempt succeeds.

Related PR: microbit-foundation/microbit-connection#25

src/get-next-connection-state.ts

…iner into radio-error

src/get-next-connection-state.ts

microbit-robert · 2024-08-05T16:27:13Z

Code changes look good. Will test tomorrow morning.

microbit-robert

LGTM. All previous change requests have been resolved.

microbit-grace added 7 commits July 30, 2024 13:13

Allow skip flashing of radio remote micro:bit when developing

a8770b3

Store radio remote device id in local storage

e1ccb32

This mimics the existing behaviour and also means that the radio remote micro:bit does not need to be flashed in order to find the device id so that step can be skipped in development mode

Show gesture data when it exists

b1a6424

WIP

dce743d

WIP

8f33c6f

Get next connection state and tests and other teaks

6eaf473

Add disconnect test scenarios for getNextConnectionState

7b79afd

microbit-grace added 7 commits August 1, 2024 12:04

Revert changes in ConnectProvider

0744591

Remove ConnectStatusProvider debugging logging

fe0a59d

Fix live graph panel use of status and tweak comments

9bdf6f9

Upgrade microbit-connection lib to v0.0.0-alpha.15

afac8dc

Close start over warning dialog when start new session is clicked

0c50724

Do not show connecting dialog when reconnecting

169535f

Aligning with existing reconnecting design

Close start over warning dialog when start new session is clicked

d23f238

microbit-grace commented Aug 1, 2024

View reviewed changes

microbit-grace marked this pull request as ready for review August 1, 2024 14:58

microbit-grace requested a review from a team August 1, 2024 14:58

microbit-robert requested changes Aug 2, 2024

View reviewed changes

Implement reconnecting UI differently depending on if reconnecting ex…

62f7dbf

…plicitly or automatically

microbit-grace mentioned this pull request Aug 2, 2024

Add final attempt to reconnect in radio bridge microbit-foundation/microbit-connection#25

Merged

Add connection fail dialogs for radio and bluetooth

1cd00cc

microbit-grace mentioned this pull request Aug 2, 2024

[WIP] Bluetooth connection fail dialog #283

Closed

microbit-grace commented Aug 2, 2024

View reviewed changes

src/get-next-connection-state.ts Outdated Show resolved Hide resolved

Remove debug console log

4b2236e

microbit-grace requested a review from microbit-robert August 2, 2024 16:12

Merge branch 'react' of https://github.com/microbit-foundation/ml-tra…

3e6d01a

…iner into radio-error

microbit-grace removed the request for review from microbit-robert August 5, 2024 10:04

microbit-grace added 3 commits August 5, 2024 11:15

Refactor useConnectStatus hooks

3fa059c

Fix use of connect status hook in merging

a650f4e

Ignore USB when radio connection is disconnected

c43f73f

microbit-grace requested review from a team and microbit-robert and removed request for a team and microbit-robert August 5, 2024 15:26

microbit-robert reviewed Aug 5, 2024

View reviewed changes

src/get-next-connection-state.ts Outdated Show resolved Hide resolved

Update get next connection state and test

e5467d2

microbit-grace requested a review from microbit-robert August 6, 2024 08:04

microbit-grace added 2 commits August 6, 2024 09:08

Add comments to get next connection state

cbbfcb5

Upgrade connection lib to 0.0.0-alpha.18

023642d

microbit-robert approved these changes Aug 6, 2024

View reviewed changes

microbit-grace merged commit 7420da2 into react Aug 6, 2024
1 check passed

microbit-grace deleted the radio-error branch August 6, 2024 09:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Handle radio connect/ reconnect error scenarios #281

Handle radio connect/ reconnect error scenarios #281

microbit-grace commented Aug 1, 2024 •

edited

Loading

github-actions bot commented Aug 1, 2024

microbit-grace Aug 1, 2024

microbit-grace Aug 1, 2024

microbit-grace Aug 1, 2024

microbit-robert commented Aug 2, 2024

microbit-robert commented Aug 2, 2024

microbit-robert commented Aug 2, 2024 •

edited

Loading

microbit-robert left a comment

microbit-grace commented Aug 2, 2024

microbit-grace commented Aug 2, 2024

microbit-robert commented Aug 5, 2024

microbit-robert left a comment

Handle radio connect/ reconnect error scenarios #281

Handle radio connect/ reconnect error scenarios #281

Conversation

microbit-grace commented Aug 1, 2024 • edited Loading

github-actions bot commented Aug 1, 2024

microbit-grace Aug 1, 2024

Choose a reason for hiding this comment

microbit-grace Aug 1, 2024

Choose a reason for hiding this comment

microbit-grace Aug 1, 2024

Choose a reason for hiding this comment

microbit-robert commented Aug 2, 2024

microbit-robert commented Aug 2, 2024

microbit-robert commented Aug 2, 2024 • edited Loading

microbit-robert left a comment

Choose a reason for hiding this comment

microbit-grace commented Aug 2, 2024

microbit-grace commented Aug 2, 2024

microbit-robert commented Aug 5, 2024

microbit-robert left a comment

Choose a reason for hiding this comment

microbit-grace commented Aug 1, 2024 •

edited

Loading

microbit-robert commented Aug 2, 2024 •

edited

Loading