Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc updates 2025 #2317

Merged
merged 21 commits into from
Jan 14, 2025
Merged

Doc updates 2025 #2317

merged 21 commits into from
Jan 14, 2025

Conversation

sierra-moxon
Copy link
Member

@sierra-moxon sierra-moxon commented Jan 8, 2025

Tidying up and reorganizing hand-written documentation in the NMDC schema repo and adding logos and text to help introduce the schema to new users.

microbiomedata/docs#54

Copy link

github-actions bot commented Jan 8, 2025

PR Preview Action v1.6.0

🚀 View preview at
https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2317/

Built to branch gh-pages at 2025-01-14 17:42 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@sierra-moxon sierra-moxon marked this pull request as ready for review January 8, 2025 15:54

We do not currently have any criteria for good typecodes, other than they are ideally between 3 and 6 characters in length.

## unresolved
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@turbomam - this is the place in the diff where I pulled the "unresolved list and made it into this ticket: #2318

@ssarrafan
Copy link
Collaborator

Sierra mentioned that Mark is reviewing this today. I'll wait till he is done. Thank you!

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and I approve. I have PR comments with some follow-up questions if you have time for them.

share, and interpret complex datasets with consistency and clarity. The NMDC Schema is critical substrate used to facilitate
interoperability and collaboration, as it provide a common language for data exchange across systems and disciplines.
In the context of the NMDC, this schema supports the integration of microbiome data from medicine, agriculture,
bioenergy, and environmental science into a cohesive platform.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better. I agree with all of the points that are made in the new paragraph. "foundational framework" and "critical substrate" sound a little jargony to me, but I don't think that justifies a lot of extra work in rewording.

@@ -173,12 +173,11 @@ $(DOCDIR):
gendoc: $(DOCDIR) prefixmaps
# Copy all documentation files to the documentation directory
cp -rf $(SRC)/docs/* $(DOCDIR)
# Added copying of images and renaming of TEMP.md
cp $(SRC)/docs/*md $(DOCDIR)
cp -r $(SRC)/docs/images $(DOCDIR)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the removed lines we just redundant with cp -rf $(SRC)/docs/* $(DOCDIR), right?


* An annotation schema that provides a mechanism for annotating data with additional information, such as provenance,
quality, and other metadata that is not part of the core data model.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't really true any more. Right now there are more than three modules (disregarding whatever "key" means), but I would like to switch to just two: one NMDC module and one GSV MIxS module

The NMDC Schema is annotated with the set of IDs, ordered by preference, that are allowed to act as primary keys
for instances of each class. For example the class [OrthologyGroup](https://microbiomedata.github.io/nmdc-metadata/docs/OrthologyGroup) has a description of the IDs allowed
on the class web page, the first listed is [KEGG.ORTHOLOGY](https://registry.identifiers.org/registry/kegg.orthology). The full URL for each is in the jsonld context file,
[jsonschema/nmdc.context.jsonld](...).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I totally get this yet, but that isn't a reason to hold up the merge.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; hard to tell from the diff, but this was text from pre-reorg. We could do another pass at refining even more of this doc.


## Credits
This schema was made using the [LinkML framework](https://github.com/biolink/biolinkml). LinkML is a data modeling language that is used to create data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that a really old URL?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch - hard to tell from the diff, but this was a link in place before I began reorg - will update.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -9,10 +9,4 @@ https://linkml.io/linkml/developers/schemaview.html#schemaview
There are also several notebooks that demonstrate SchemaView usage in the LinkML-runtime repository:
https://github.com/linkml/linkml-runtime/tree/main/notebooks

Finally, the Biolink Model Toolkit is a helper wrapper around SchemaView for use with the Biolink Model and it
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sierra-moxon you're the expert here so I trust you. Can you just say a little more about removing these lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured for review from external sources, that this is internal documentation that someone who wants to know about writing a SchemaView wrapper could get from me (or already has gotten) and so doesn't need to be part of the official NMDC doc any longer.

@sierra-moxon sierra-moxon merged commit 3a89ad0 into main Jan 14, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants