Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Mappings table to reduce redundancy #2304

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Conversation

sujaypatil96
Copy link
Collaborator

Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2304/
on branch gh-pages at 2024-12-18 23:26 UTC

@sujaypatil96
Copy link
Collaborator Author

@turbomam
Copy link
Member

turbomam commented Jan 6, 2025

Ideally there wouldn't be any table at all on
https://microbiomedata.github.io/nmdc-schema/pr-preview/pr-2304/DataObject/
but I don't think that should be a blocker for merging this.

@turbomam
Copy link
Member

turbomam commented Jan 6, 2025

oops got distracted

@turbomam
Copy link
Member

turbomam commented Jan 6, 2025

note to self: native mappings appear to always be default prefix + element name

self appears to be the element's asserted URI (class_uri, slot_uri, etc.), or the native mapping if no URI was asserted

@turbomam : Put this in a schemaView docstring

Copy link
Member

@turbomam turbomam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but please see this when convenient:

@sujaypatil96 sujaypatil96 merged commit 8749b7e into main Jan 6, 2025
3 checks passed
@sujaypatil96 sujaypatil96 deleted the linkml-issue-2438 branch January 6, 2025 17:55
@turbomam
Copy link
Member

turbomam commented Jan 6, 2025

note that the temporary docs links above may have been retired

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify Mappings table shown on documentation pages to be more informative
2 participants