Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

splitOn error is not clear if using a wrong column name #647

Open
artur-sannikov opened this issue Oct 4, 2024 · 1 comment
Open

splitOn error is not clear if using a wrong column name #647

artur-sannikov opened this issue Oct 4, 2024 · 1 comment

Comments

@artur-sannikov
Copy link
Contributor

If I have a SummarizedExperiment, want to split it by group and specify a non-existing column, I get a generic Error: 'group' is not found. Please check that 'group' specifies a column from rowData or colData.

> splitOn(se, "Treatment")
Error: 'group' is not found. Please check that 'group' specifies a column from rowData or colData.

Treatment column does not exist here.

The error can be improved: Error: column 'Treatment' is not found. Please check that this column exists in rowData or colData.

@TuomasBorman
Copy link
Contributor

Thanks!

This is a thing that we can improve. However, it seems that most of the error messages are in former format. Not sure, if we should then improve them all. It is better that messages informing a similar thing are structured similarly. That is done in HoloFoodR (a common function for creating error messages), and we could use it as a template. However, this is not currently top priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants