-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container host to MQTT events #30
base: master
Are you sure you want to change the base?
Conversation
Not sure why you would need this info in the event? The discovery topic should already contain the relevant information and can be used to identify the server. I'd prefer to avoid adding data to the event, which is redundant and just increases bandwidth for mqtt. |
Information available in the discovery topic
What is your usecase which is not covered by this? |
Thanks, Totally understand wanting to keep the MQTT payloads light. The main use case is that I've got the entities fed into a flex-table-card in homeassistant and it's useful to be able to sort+filter based on the host they're running on. I agree the data is in the friendly_name of the entity but its not an easy or clean field to present the data with. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reasonable I guess :)
@mscottco Please check with the workflows that the types are correctly set. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you run the mypy task locally in your repo?
Hope it's okay to open a pull request against your repo. This change is to add the container host to the MQTT events so it appears as an attribute in Homeassistant so its a bit easier to tell which containers are running where...