Add onclick to action element #2957
Conversation
fix(fonts): update @ukic/fonts version to fix failing release
Develop -> Main
- @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected] - @ukic/[email protected]
add a new dismissLabel prop which allows the user to change the text of the label on the dismiss button feat mi6#2839
Add prop to customise tooltip label for chip. Add Cypress test and stories . mi6#2839
…agination-bar-items-per-page-prop Prevent duplication of pagination bar items per page dropdown items
…p-text feat(web-components): [ic-chip] add prop to customise tooltip text
adds test for action element in data-table
…-data-table cell Allow specifying target and rel attribute for the anchor tag in the cell, along with the href. There are existing styles that add a new window icon to the link when the target is "_blank" and so no change is required to achieve that. Ref: mi6#2751
… to include new target key This change also removes the incorrect keys from the example code that seem to have been left over from a copy and paste from a different example. Closes: mi6#2751
feat(canary-web-components): allow specifying target for anchor in ic-data-table cell
…-test test(canary-react): adds visual test for action elements
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome 👋
Welcome to the ic-ui-kit repo, thank you for submitting a pull request!
How to contribute
Please read our CONTRIBUTING.md, which explains our ways of working and guidelines for contributions.
Code of Conduct
We'd appreciate it if you could read and abide by our Code of Conduct, as we wish to foster an inclusive and respectful community.
Targeting your pull request
We use develop rather than main as the base for contributions - please make sure your PR is targeting develop.
Signing the CLA
We require all contributors to sign our Contributor License Agreement (CLA) before we can accept a contribution. If you are contributing on behalf of an organization please follow your organization's policies in signing CLAs.
Associated issue
Please make sure that your pull request has an issue open - this allows us to keep track of changes made and offer support where needed.
|
Thanks for your contribution, you just need to run prettier to fix the broken GitHub checks, then a member of the team will take a look. |
Should be all sorted now. Thanks |
There was a problem hiding this comment.
It would be good to add some documentation about the actionElement and actionOnClick. This would make it much clearer for users as at the moment you have to look into the code or examples to discover that this functionality exists.
Maybe just expand the Action Element story (ideally in both canary-web-components & canary-react) to add more info describing the functionality (and maybe why users might want to go with this approach rather than using slotted elements)
Co-authored-by: ad9242 <[email protected]>
GCHQ-Developer-112
force-pushed
the
develop
branch
from
65d32e1 to
a7135b5
Compare
Summary of the changes
In the data table on the data prop, where the action element is added, i have added an on click to the actionElement, with a ternary to only use click when a prop is passed.
Related issue
2943
Checklist
General
Testing
Accessibility
Resize/zoom behaviour
System modes
Testing content extremes