2722 popover menu toggle variant menu items cause accessibility error #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2722-popover-menu-toggle-variant-menu-items-cause-accessibility-error/web-components |
GCHQ-Developer-112
force-pushed
the
2722-popover-menu-toggle-variant-menu-items-cause-accessibility-error
branch
from
e5a0849 to
5f39c9f
Compare
…ckground fixes components that are displayed on brand coloured background
fixes components that are displayed on brand coloured background
fixes components that are displayed on brand coloured background
Theme from context fix
Update icon colours for dark mode badge to match the text colour of badges in dark mode . #2910
Update fonts package to alpha versioning for v3 to stop clashes with v2 releases BREAKING CHANGE: Package version updated to 3.0.0-alpha.0
Update icon colours for dark mode badge and add tests to capture dark mode icons
chore(fonts): update fonts package to alpha versioning for v3
updates snapshot file for v3 data-table tests
adds test for action element in data-table
…pagination-bar-items-per-page-prop cherry pick : prevent mutation of ic-pagination-bar items per page options prop
V3 data table tests
docs changes for ic-chip
added prop to change the dismiss label of ic-chip
added tests for custom dismiss label in ic-chip
Cherry pick/tooltip dismiss label
…mpty options array Fix ic-select where no options was able to be selected by refactoring customSelectChange function
test to ensure no value is passed in ic-select when 'no options' is selected
updates examples after ic-theme prop changes
updates to canary-docs package after ic-theme changes
updates to docs package after ic-theme changes
keeps canary components in sync with changes made to ic-theme component BREAKING CHANGE: change to IcTheme types, now IcBrand
changes to ic-theme component to rename prop and events BREAKING CHANGE: color prop renamed to brandColor icThemeChange event renamed to icBrandChange changes to types: IcThemeForegroundEnum now IcBrandForegroundEnum IcThemeForeground now IcBrandForeground IcThemeForegroundNoDefault now IcBrandForegroundNoDefault IcTheme now IcBrand
changes to tests and storybook examples following changes to ic-theme component BREAKING CHANGE: BREAKING CHANGE: color prop renamed to brandColor icThemeChange event renamed to icBrandChange changes to types: IcThemeForegroundEnum now IcBrandForegroundEnum IcThemeForeground now IcBrandForeground IcThemeForegroundNoDefault now IcBrandForegroundNoDefault IcTheme now IcBrand
Ic theme color prop rename
fix(web-components): select bugfix
…t-icons-are-showing-as-the-wrong-colour 2910 ic badge dark mode info variant icons are showing as the wrong colour
…ponent storybooks
…x accessibility issues Remove nested ic-button within the toggle variant of ic-menu-item to fix accessibility issues. Rename ic-popover-menu CSS tokens. Update tests and stories . #2722
…gle variant of ic-menu-item Uncomment Cypress accessibility tests that were previously failing . #2722
GCHQ-Developer-112
force-pushed
the
2722-popover-menu-toggle-variant-menu-items-cause-accessibility-error
branch
from
5f39c9f to
3084bd5
Compare
GCHQ-Developer-112
force-pushed
the
v3.0.0/develop
branch
from
88e126d to
49484eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
ic-buttonwithin the toggle variant ofic-menu-itemto fix accessibility issues.ic-popover-menuCSS tokensRelated issue
#2722
Checklist
General
Testing
Accessibility