1960 ic text field autofocus prop not working unless text field label is hidden #2901
+135
−66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/1960-ic-text-field-autofocus-prop-not-working-unless-text-field-label-is-hidden/web-components |
gd2910
force-pushed
the
1960-ic-text-field-autofocus-prop-not-working-unless-text-field-label-is-hidden
branch
4 times, most recently
from
d116d90 to
0abf36b
Compare
gd2910
force-pushed
the
1960-ic-text-field-autofocus-prop-not-working-unless-text-field-label-is-hidden
branch
2 times, most recently
from
f4d6c15 to
acf784e
Compare
ad9242
requested changes
Dec 31, 2024
packages/web-components/src/components/ic-text-field/ic-text-field.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/ic-text-field/ic-text-field.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/ic-text-field/ic-text-field.tsx
Outdated
Show resolved
Hide resolved
packages/web-components/src/components/ic-text-field/ic-text-field.tsx
Outdated
Show resolved
Hide resolved
GCHQ-Developer-847
requested changes
Jan 2, 2025
gd2910
force-pushed
the
1960-ic-text-field-autofocus-prop-not-working-unless-text-field-label-is-hidden
branch
from
acf784e to
e9c3d77
Compare
GCHQ-Developer-112
force-pushed
the
v3.0.0/develop
branch
from
88e126d to
49484eb
Compare
bugfix for when autofocus prop would only work when label was hidden and small prop rename for v3 BREAKING CHANGE: prop rename from auto-focus to autofocus, more closely aligning with native html attribute
added cypress test and react storybook for autofocus attribute
ic-text-field docs update BREAKING CHANGE: prop rename to more closely align with native html attribute
gd2910
force-pushed
the
1960-ic-text-field-autofocus-prop-not-working-unless-text-field-label-is-hidden
branch
from
e9c3d77 to
671641a
Compare
GCHQ-Developer-847
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes
autofocuswas only being applied when the label was hidden, this was due to the child components rendering after theic-text-fieldcomponents.Changes;
setIntervalwaits until typography is hydrated before setting focus on inputautofocusrenamed fromauto-focusto align more closely with native attributeRelated issue
#1960