Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: version and metadata for packages at runtime #2617

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

evenstensberg
Copy link
Contributor

@evenstensberg evenstensberg commented Oct 18, 2024

Summary of the changes

Adds build metadata for customers.

Related issue

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@evenstensberg evenstensberg marked this pull request as ready for review October 18, 2024 22:14
@evenstensberg
Copy link
Contributor Author

evenstensberg commented Oct 18, 2024

This implements env vars for all packages in the ui-kit repo. Whenever you release, the env vars gets updated.

The variables are sealed/frozen so that no external logic can set the package versions.

It would be good if you could elaborate how you release, so I can figure out how the releasing affects the setting of the environment variables. Let me know what you think. Thx.

@evenstensberg evenstensberg changed the title chore: version packages chore: version and metadata for packages at runtime Oct 19, 2024
@evenstensberg
Copy link
Contributor Author

@GCHQ-Developer-530 Any progress on contributor swag? 😅

@GCHQ-Developer-530
Copy link
Contributor

@GCHQ-Developer-530 Any progress on contributor swag? 😅

Not yet, it's not something we've had the opportunity to delve into properly yet due to being busy with v3 work etc.

@evenstensberg
Copy link
Contributor Author

@GCHQ-Developer-530 Any progress on contributor swag? 😅

Not yet, it's not something we've had the opportunity to delve into properly yet due to being busy with v3 work etc.

@GCHQ-Developer-530 Can I send you my address so I don't need to ask you more times?

@GCHQ-Developer-530
Copy link
Contributor

@GCHQ-Developer-530 Any progress on contributor swag? 😅

Not yet, it's not something we've had the opportunity to delve into properly yet due to being busy with v3 work etc.

@GCHQ-Developer-530 Can I send you my address so I don't need to ask you more times?

That would go against our code of conduct for not sharing personally identifiable information. We will get back to you if we have any further information about swag.

@evenstensberg
Copy link
Contributor Author

@GCHQ-Developer-530 Any progress on contributor swag? 😅

Not yet, it's not something we've had the opportunity to delve into properly yet due to being busy with v3 work etc.

@GCHQ-Developer-530 Can I send you my address so I don't need to ask you more times?

That would go against our code of conduct for not sharing personally identifiable information. We will get back to you if we have any further information about swag.

@GCHQ-Developer-530 aha okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants