Fix bug in tosc_reset #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tosc_reset was operating on offsets based on the location of the format (o->format). When it came time to adjust the marker location to a multiple of 4 bytes it adjusted that index to a multiple of 4 bytes, which gives you a location aligned relative to o->format. But the location needs aligned relative to the entire buffer. This change re-writes tosc_reset to operate entirely relative to the buffer start rather than to the start of the format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tosc_reset was operating on offsets based on the location of the format (o->format). When it came time to adjust the marker location to a multiple of 4 bytes it adjusted that index to a multiple of 4 bytes, which gives you a location aligned relative to o->format. But the location needs aligned relative to the entire buffer.
This change re-writes tosc_reset to operate entirely relative to the buffer start rather than to the start of the format.