Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up sample_rate_offset() and frequency_offset() #368

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

mhostetter
Copy link
Owner

Fixes #343

@mhostetter mhostetter added the impairment Related to impairments label Jun 1, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 79.33%. Comparing base (1e1bb5a) to head (666ff3e).

Files Patch % Lines
src/sdr/_simulation/_impairment.py 20.00% 8 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release/0.0.x     #368      +/-   ##
=================================================
- Coverage          79.40%   79.33%   -0.07%     
=================================================
  Files                 63       63              
  Lines               3782     3770      -12     
=================================================
- Hits                3003     2991      -12     
  Misses               779      779              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhostetter mhostetter merged commit ed2d694 into release/0.0.x Jun 1, 2024
26 checks passed
@mhostetter mhostetter deleted the mhostetter/issue343 branch June 1, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impairment Related to impairments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants