Check for and handle None docstrings #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you rebase this off of mhostetter:release/0.3.x? That is required to pass the tests. |
jcharlong
force-pushed
the
support-optimized-out-docstrings
branch
from
edf157e to
bc9d933
Compare
|
Sure thing, just pushed after rebasing. |
|
The latest macos CI runners have screwed things. I've got to debug this before the tests can work. Hang tight. |
|
Can you rebase off of |
CPython's -OO flag optimizes out docstrings sets them to None.
jcharlong
force-pushed
the
support-optimized-out-docstrings
branch
from
bc9d933 to
9460825
Compare
|
Sure thing, just pushed after rebasing. Thanks for your quick turn around time in debugging, I appreciate it. |
|
Thanks! I'll push a new release tonight. |
|
Great, thanks again for the quick support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #544
I confirmed that I ran into the issue by running tests w/
python -OO -m pytest tests/. The issue is resolved & all tests completed after this update.Let me know if there are any version or release notes I should be handling in this PR. I could not find any guidelines on this for developers in the repository's documentation.