Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specific permissions to workflows under .github/workflows #20

Merged
merged 3 commits into from
Sep 15, 2021
Merged

Add specific permissions to workflows under .github/workflows #20

merged 3 commits into from
Sep 15, 2021

Conversation

varunsh-coder
Copy link
Contributor

This PR adds specific permissions to the existing workflows under .github/workflows.

Background

I have implemented a GitHub App to automatically restrict permissions for the GITHUB_TOKEN in workflows. This is a security best practice as per the GitHub Actions hardening guide.

I am trying the App out on public repositories, by forking them, installing the App on the fork, and manually creating PRs with the fixed workflows. The App automatically fixes permissions when a PR is created that creates a new workflow, so feel free to install it for future workflows, or try it out on other repos.

I have manually reviewed the changes, and they do look good to me. If something looks off, please let me know. If you have feedback, would love to hear it. Thanks!

@mgdm
Copy link
Owner

mgdm commented Sep 12, 2021

Hi,
There was another PR to fix the upload of binaries to the releases. That's caused some conflicts in here unfortunately. If it's still a good idea, would you be able to rebase? If not, I can have a look myself.

Thanks!

@varunsh-coder
Copy link
Contributor Author

I have resolved the conflict. Please let me know if you have any questions about the changes.

@mgdm mgdm merged commit 28adf17 into mgdm:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants