-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support to restricted collection item size #510
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #510 +/- ##
==========================================
+ Coverage 94.21% 94.37% +0.16%
==========================================
Files 21 21
Lines 3148 3238 +90
Branches 496 507 +11
==========================================
+ Hits 2966 3056 +90
Misses 118 118
Partials 64 64 ☔ View full report in Codecov by Sentry. |
Is this ready to merge? |
Functionally ready but could use a flag\check to only generate the simple types when they are required/useful. Current example if the user doesn't want data-annotation, I can't think of a reason to use the simple types. I also want to auto generate implicit casts but that seems to be a bit to much to put in this PR |
So perhaps they should be enabled by default if DataAnnotations are enabled and disabled by default if DataAnnotations are disabled?
That would be great. Let me know when you want to merge. |
This is a real quick re-apply of some code that I used to add support for collections with a specified min/max occurs as well as a primitive type that has its own restrictions.