Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unit test failures with newer sklearn #269

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Avoid unit test failures with newer sklearn #269

merged 4 commits into from
Jun 25, 2024

Conversation

mgalardini
Copy link
Owner

With sklearn > 1.5.0 I encountered we now get a different non-metric MDS

@mgalardini
Copy link
Owner Author

I found a way to have the same environment as github actions locally, because I am not seeing these errors in my setup:

| =========================== short test summary info ============================                                                                                                                                 
| FAILED tests/enet_test.py::TestFitEnet::test_fit_binary - IndexError: index 1 is out of bounds for axis 1 with size 1                                                                                            
| FAILED tests/enet_test.py::TestFitEnet::test_fit_continuous - AttributeError: module 'numpy' has no attribute 'NAN'                                                                                              
| ================== 2 failed, 42 passed, 54 warnings in 5.25s ===================

Hopefully I'll find a way to fix it, will push commit here

Unclear what is the underlying cause of the error, but downgrading
glmnet_py to 1.0.0 fixed the issue
@mgalardini mgalardini merged commit 45b27a6 into master Jun 25, 2024
1 check passed
@mgalardini mgalardini deleted the test_fix branch June 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant