Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove constraints urllib3<2.0.0 #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

mfarhan943
Copy link
Owner

Description

Describe what this pull request changes, and why. Include implications for people using this change.
Design decisions and their rationales should be documented in the repo (docstring / ADR), per
OEP-19, and can be
linked here.

Useful information to include:

  • Which edX user roles will this change impact? Common user roles are "Learner", "Course Author",
    "Developer", and "Operator".
  • Include screenshots for changes to the UI (ideally, both "before" and "after" screenshots, if applicable).
  • Provide links to the description of corresponding configuration changes. Remember to correctly annotate these
    changes.

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@mfarhan943 mfarhan943 force-pushed the farhan/remove-urllib3-constraint branch 7 times, most recently from 47efd57 to b35c464 Compare September 25, 2024 15:12
@mfarhan943 mfarhan943 force-pushed the farhan/remove-urllib3-constraint branch 3 times, most recently from d8458ef to 0458cf9 Compare October 17, 2024 10:22
bmtcril and others added 5 commits October 17, 2024 10:10
Currently all PRs are failing on an INTERNAL ERROR in MyPY that seems to
have been introduced in 1.12.0. This pins edx-platform to <1.12.0 until
we can find out more information and hopefully get an upstream fix.
The MyPY constraint is propagated to development.txt
build: Pin MyPY due to internal error
@mfarhan943 mfarhan943 force-pushed the farhan/remove-urllib3-constraint branch from 0458cf9 to d30c962 Compare October 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants