-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependency psr/http-message to v2 #39
Conversation
Please do not just merge this, there is no check which verifies that So in this case, for This will become: lowest{
"require": {
"psr/http-message": "^1.0"
}
} latest{
"require": {
"psr/http-message": "^2.0"
}
} We had the same issue in So most probably, for every dependency which declares multiple major versions, a matrix job needs to be created which enforces all major versions so that we can actually verify that we do install them. Any ideas/thoughts on this @mezzio/technical-steering-committee? I think that Matthew also meant this kind of check here. |
@boesing Also... I'll have PRs incoming this week for Diactoros around this. I think once those are in place, we can tackle some of these. In most cases for consumers, however, we should be able to allow |
c53ed32
to
5a1bda1
Compare
c7f36bd
to
61d93b0
Compare
4a946c2
to
62936fb
Compare
0697de5
to
48e2199
Compare
| datasource | package | from | to | | ---------- | ---------------- | ---- | --- | | packagist | psr/http-message | 1.1 | 2.0 | Signed-off-by: Renovate Bot <[email protected]>
48e2199
to
20ac074
Compare
Signed-off-by: Aleksei Khudiakov <[email protected]>
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is currently testing on both major versions for lowest/latest.
Given that we don't currently have a workflow for testing strategies per major release of deps, do you have any objection to merging and releasing @boesing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, can confirm both versions are being tested with this PR:
https://github.com/mezzio/mezzio-problem-details/actions/runs/4904438255/jobs/8757514065?pr=39#step:3:248
https://github.com/mezzio/mezzio-problem-details/actions/runs/4904438552/jobs/8757514572?pr=39#step:3:290
LGTM, I think we can 🚢 now
This PR contains the following updates:
^1.0
->^1.0 || ^2.0
Release Notes
php-fig/http-message
v2.0
Compare Source
Added return types, see https://www.php-fig.org/psr/psr-7/meta/[#​72](https://togithub.com/php-fig/http-message/issues/72)-type-additions
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
Read more information about the use of Renovate Bot within Laminas.