-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature bug fix #21
Feature bug fix #21
Conversation
I'm happy to this is my second PR too. This also solved another issue #16 with commit c5d75bf as suggested @sansyrox I've disabled minify temporarily and allowed to only css files from the browser. I've made one small change in package.json made I'll soon open one PR to minify the CSS versions. Thank You. |
Hi @nimit2801 , can you please remove the package-lock.json from the commits? We don't commit them in the repo. |
yeah sure, I'll remove it from the commit. |
Hi @nimit2801 , Looks good. I would've given you marks of 50 + 50, i.e. two medium issues. But I'll give you 100 in a single one. |
Description
The project won't work on the node versions above 15.xx, because there's a dependency node-sass that needs 14.xx and lower.
Motivation and Context
#20
How Has This Been Tested?
Types of changes
Checklist: