Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature bug fix #21

Merged
merged 5 commits into from
Feb 12, 2021
Merged

Feature bug fix #21

merged 5 commits into from
Feb 12, 2021

Conversation

nimit2801
Copy link
Contributor

@nimit2801 nimit2801 commented Feb 9, 2021

Description

The project won't work on the node versions above 15.xx, because there's a dependency node-sass that needs 14.xx and lower.
image

Motivation and Context

  • This change was required because the project won't run on the current version of the node (15.xx and above)

#20

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@nimit2801
Copy link
Contributor Author

@nimit2801
Copy link
Contributor Author

I'm happy to this is my second PR too.
Also @sansyrox I couldn't make new PR this commit was automatically included in the existing PR.

This also solved another issue #16 with commit c5d75bf as suggested @sansyrox I've disabled minify temporarily and allowed to only css files from the browser.
This would allow normal working of the css framework and help the project run smoothly.

I've made one small change in package.json made
"server" : "nodemon server.js" => "server" : "node server.js"
Reason: As new files were generated in on the backend in the temp folder the server was restarting detecting the temp files added which made the server restart, which can cause delay and loss API calls on the server.

I'll soon open one PR to minify the CSS versions. Thank You.

@sansyrox
Copy link
Member

sansyrox commented Feb 9, 2021

Hi @nimit2801 , can you please remove the package-lock.json from the commits? We don't commit them in the repo.

@nimit2801
Copy link
Contributor Author

Hi @nimit2801, can you please remove the package-lock.json from the commits? We don't commit them in the repo.

yeah sure, I'll remove it from the commit.

@nimit2801
Copy link
Contributor Author

@sansyrox

  1. Deleted backend/package-lock.json and client/package-lock.json from the main branch.
  2. Added both files to .gitignore. with
    732efe8 and 147740f

@sansyrox
Copy link
Member

Hi @nimit2801 ,

Looks good. I would've given you marks of 50 + 50, i.e. two medium issues. But I'll give you 100 in a single one.

@sansyrox sansyrox merged commit c4f2324 into mexili:main Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants