fix: use global() to get performance API on wasm32-unknown-unknown #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobz
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Thanks for opening this PR!
Taking a look at the code, it seems like this is going to be somewhat inefficient, reflecting through the global scope on every single call.
Is my intuition wrong here? Could we not instead simply query for the Performance class when constructing Monotonic so that there's always a live reference to it to directly use?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently quanta uses
window.performanceto access Performance API in browser, which will not work in WebWorkers. In WebWorkers, there is nowindowobject, butperformanceis in the global space.This PR uses
web_sys::js_sys::global()to access the global scope, and look up forperformancein that, which will both work on webpage and WebWorkers.See https://developer.mozilla.org/en-US/docs/Web/API/Web_Workers_API/Functions_and_classes_available_to_workers for more details