Dont add user to master realm if they don't have keycloak_admin role …

…from MSSP
methics · Oct 19, 2023 · 0c2a04c · 0c2a04c
1 parent 733a8df
commit 0c2a04c
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/main/java/fi/methics/keycloak/laverca/MobileidAuthenticator.java b/src/main/java/fi/methics/keycloak/laverca/MobileidAuthenticator.java
@@ -148,6 +148,12 @@ public void action(AuthenticationFlowContext context) {
                 UserModel existingUser = session.users().getUserByUsername(realm, msisdn);
                 UserModel user = (existingUser == null) ? this.createUser(context, msisdn, resp) : existingUser;
 
+                // User returned null because MSSP user did not have "keycloak_admin" role
+                if (user == null) {
+                    context.failure(AuthenticationFlowError.ACCESS_DENIED);
+                    return;
+                }
+
                 // Set attributes and roles for current user
                 this.setAttributes(user, attrs, resp);
                 context.setUser(user);
@@ -229,8 +235,9 @@ private UserModel createUser(AuthenticationFlowContext context, String msisdn, M
         if (realm.getName().equals("master")) {
             if (!roles.contains("keycloak_admin")) {
                 logger.warn("Can't give Keycloak ADMIN access to " + newUser.getUsername() +
-                            " because mobile user did not have 'keycloak_admin' role");
-                return newUser;
+                            " because mobile user did not have 'keycloak_admin' role.");
+                // Return null so no extra users are created
+                return null;
             }
 
             RoleModel adminRole = realm.getRole("admin");