-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PhACE architecture #434
Draft
frostedoyster
wants to merge
197
commits into
main
Choose a base branch
from
phace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+38,156
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor (creator of pull-request) checklist
[docs/src/dev-docs/architecture-life-cycle.rst](Architecture life cycle) document for
requirements.
src/metatrain/experimental/<architecture_name>
src/metatrain/experimental/<architecture_name>/default-hypers.yml
.yml
file into github workflows.github/workflow/<architecture_name>.yml
optional-dependencies
section in thepyproject.toml
Reviewer checklist
New experimental architectures
tests.
TorchScript <https://pytorch.org/docs/stable/jit.html>
_.__maintainers__
and theCODEOWNERS
filePyPI, a public git repository or another public URL with a repository is acceptable.
New stable architectures
file.
PyPI.
metatrain
, includinglogging and model save locations.
📚 Documentation preview 📚: https://metatrain--434.org.readthedocs.build/en/434/