Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: package alpine and ubuntu x86_64 versions in tebako docker containers #229

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat: package alpine and ubuntu x86_64 versions in tebako docker containers #229

merged 2 commits into from
Jul 1, 2024

Conversation

maxirmx
Copy link
Contributor

@maxirmx maxirmx commented Jun 26, 2024

Metanorma PR checklist

@maxirmx maxirmx force-pushed the use-tebako-containers branch from f68e22d to f93ebc9 Compare June 28, 2024 14:26
@maxirmx maxirmx changed the title Packaging in tebako docker container with Ruby to 3.1.5 Packaging in tebako docker container with Ruby 3.1.6 Jun 28, 2024
@maxirmx maxirmx force-pushed the use-tebako-containers branch 2 times, most recently from 7ab4b40 to ab7f065 Compare June 30, 2024 11:19
@maxirmx maxirmx self-assigned this Jun 30, 2024
@maxirmx maxirmx changed the title Packaging in tebako docker container with Ruby 3.1.6 feat: package alpine and ubuntu x86_64 versions in tebako docker containers Jun 30, 2024
@maxirmx maxirmx force-pushed the use-tebako-containers branch from 09351bb to d27d336 Compare June 30, 2024 21:15
@maxirmx maxirmx marked this pull request as ready for review June 30, 2024 22:27
@maxirmx
Copy link
Contributor Author

maxirmx commented Jun 30, 2024

This PR introduces packaging in tebako container.
While the difference does not look significant it elimiante the need to run setup and maintain cache.
Any feedback abou containers/containers README (https://github.com/tamatebako/tebako-ci-containers) is also much appreciated.

@ronaldtse
Copy link
Contributor

Thank you @maxirmx . Hopefully soon we can change all jobs to Tebako containers or pre-packaged files so the build can happen without any setup steps.

@ronaldtse
Copy link
Contributor

The JCGM and BIPM failures are unrelated. Merging.

@ronaldtse
Copy link
Contributor

@CAMOBAP @maxirmx Tebako seems to need some caching for users. Can we have some sort of cache action that helps users with their own Tebako build cache?

@ronaldtse ronaldtse merged commit 247bc25 into main Jul 1, 2024
76 of 86 checks passed
@maxirmx maxirmx deleted the use-tebako-containers branch December 24, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronaldtse ronaldtse ronaldtse approved these changes

Assignees

@maxirmx maxirmx

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxirmx @ronaldtse