Misc API changes #37
Merged
Misc API changes #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* DB passes are now separated into `get` and `get_or_insert` style methods. Fixes #24 (not the follow on stuff though) * `SegmentSet` and any function referencing it is now `pub(crate)`. * Implement `FormulaRef` and the display impl. The debug impl is TODO. * Most uses of `&Arc<T>` in parameters are replaced with `&T`, unless cloning is actually required in the body.
tirix
reviewed
Oct 15, 2021
tirix
reviewed
Oct 15, 2021
tirix
reviewed
Oct 15, 2021
tirix
reviewed
Oct 15, 2021
tirix
reviewed
Oct 15, 2021
tirix
reviewed
Oct 15, 2021
tirix
reviewed
Oct 15, 2021
tirix
reviewed
Oct 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getandget_or_insertstylemethods. Fixes High-level database API #24 (not the follow on stuff though)
SegmentSetand any function referencing it is nowpub(crate).FormulaRefand the display impl. The debug impl is TODO.&Arc<T>in parameters are replaced with&T,unless cloning is actually required in the body.