Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tolerations parsing #111

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Fix tolerations parsing #111

merged 1 commit into from
Sep 29, 2024

Conversation

GuyCarmy
Copy link
Contributor

The way the chart parse tolerations doesn't match the example given in your values file.

This is an easy fix as suggested in this PR.
Also you might have the same issue in other places but I didn't check or need them.

before the fix:

      tolerations:
        - effect: NoSchedule
key: kubernetes.azure.com/scalesetpriority
operator: Equal
value: spot

after the fix

      tolerations:
        - effect: NoSchedule
          key: kubernetes.azure.com/scalesetpriority
          operator: Equal
          value: spot

*also validated with 2 tolerations and with zero tolerations

      tolerations:
        - effect: NoSchedule
          key: kubernetes.azure.com/scalesetpriority
          operator: Equal
          value: spot
        - effect: NoSchedule
          key: test
          operator: Equal
          value: spot

Copy link
Member

@aviramha aviramha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aviramha aviramha merged commit 2349c3c into metalbear-co:main Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants