Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP add support for ironic-standalone-operator #1466

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

WIP add support for ironic-standalone-operator #1466

wants to merge 3 commits into from
+136 −27

Conversation

dtantsur
Copy link
Member

Signed-off-by: Dmitry Tantsur [email protected]

@metal3-io-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@metal3-io-bot metal3-io-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign rozzii for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2024
@dtantsur dtantsur force-pushed the ironic-standalone-operator branch 2 times, most recently from c94ffab to 76c7680 Compare October 30, 2024 11:17
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 30, 2024
dtantsur added a commit to dtantsur/ironic-standalone-operator that referenced this pull request Nov 6, 2024
@dtantsur
Add an environment file and a configmap to customize the manager
6e9c4fb 
Doing so simplifies downstream customizations, e.g. in metal3-dev-env:
metal3-io/metal3-dev-env#1466.

Signed-off-by: Dmitry Tantsur <[email protected]>
@dtantsur dtantsur mentioned this pull request Nov 6, 2024
Merged
@dtantsur
Copy link
Member Author

dtantsur commented Nov 7, 2024

/test metal3-dev-env-integration-test-ubuntu-main

Should be solved now

tuminoid
tuminoid reviewed Nov 7, 2024
View reviewed changes
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its WIP, but two tiny nits, and one question.

The whole file needs cleanup on Bash so not picking on any of that, this PR is following convention just fine.

lib/common.sh Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
03_launch_mgmt_cluster.sh Outdated Show resolved Hide resolved
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2024
@dtantsur dtantsur force-pushed the ironic-standalone-operator branch 5 times, most recently from 9ec2532 to e7c25d5 Compare November 8, 2024 16:22
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2024
@dtantsur dtantsur force-pushed the ironic-standalone-operator branch 3 times, most recently from 9720d0d to bd4eb00 Compare November 18, 2024 17:03
@dtantsur dtantsur force-pushed the ironic-standalone-operator branch 3 times, most recently from 351e30f to 1544a85 Compare November 24, 2024 12:30
@dtantsur
Copy link
Member Author

/test metal3-dev-env-integration-test-ubuntu-main

@dtantsur
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-8

@dtantsur
Copy link
Member Author

/test metal3-centos-e2e-integration-test-release-1-8

@metal3-io-bot
Copy link
Collaborator

@dtantsur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-dev-env-integration-test-ubuntu-main f1a4d88 link true /test metal3-dev-env-integration-test-ubuntu-main
metal3-centos-e2e-integration-test-release-1-8 66876f7 link true /test metal3-centos-e2e-integration-test-release-1-8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@metal3-io-bot
Copy link
Collaborator

@dtantsur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-dev-env-integration-test-ubuntu-main f1a4d88 link true /test metal3-dev-env-integration-test-ubuntu-main
metal3-centos-e2e-integration-test-release-1-8 66876f7 link true /test metal3-centos-e2e-integration-test-release-1-8

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tuminoid tuminoid tuminoid left review comments

@kashifest kashifest Awaiting requested review from kashifest

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtantsur @metal3-io-bot @tuminoid