Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use UEFI instead of legacy as default boot mode #1326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

use UEFI instead of legacy as default boot mode #1326

wants to merge 1 commit into from

Conversation

Rozzii
Copy link
Member

@Rozzii Rozzii commented Dec 18, 2023 •
edited
Loading

Apart from recent potential issues related to using bios, uefi default makes more sense in general as for a long time all enterprise hardware is either using uefi or secure-uefi.

This commit:

  • switched the default libvirt boot loader firmware from bios to the more modern uefi

@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 18, 2023
@Rozzii
Copy link
Member Author

Rozzii commented Dec 18, 2023

/test-centos-integration-release-1-5
/test-ubuntu-e2e-integration-main

@Rozzii
Copy link
Member Author

Rozzii commented Dec 18, 2023

/cc @dtantsur @kashifest @lentzi90 @mquhuy

@Rozzii Rozzii force-pushed the uefi_default branch 2 times, most recently from 1667311 to e3ac45c Compare December 18, 2023 10:30
@Rozzii
Copy link
Member Author

Rozzii commented Dec 18, 2023

/test-centos-integration-release-1-5
/test-ubuntu-e2e-integration-main

dtantsur
dtantsur reviewed Dec 18, 2023
View reviewed changes
vars.md Show resolved Hide resolved
@Rozzii
Copy link
Member Author

Rozzii commented Dec 18, 2023

/test-centos-integration-release-1-5
/test-ubuntu-e2e-integration-main

@tuminoid
Copy link
Member

/retitle use UEFI instead of legacy as default boot mode

@metal3-io-bot metal3-io-bot changed the title use ufei default instead of bios use UEFI instead of legacy as default boot mode Dec 18, 2023
@Rozzii
Copy link
Member Author

Rozzii commented Dec 18, 2023

/test-centos-integration-release-1-5
/test-ubuntu-e2e-integration-main

tuminoid
tuminoid reviewed Dec 18, 2023
View reviewed changes
config_example.sh Outdated Show resolved Hide resolved
@Rozzii
Copy link
Member Author

Rozzii commented Dec 18, 2023

/hold
holding it until I am sure which error was fixed by this metal3-io/ironic-image#463 if any.
I would like to see which issue causes which error.

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2023
lentzi90
lentzi90 reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
I want to do the same in BMO e2e tests

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2023
@dtantsur
Copy link
Member

I think defaulting to UEFI is a reasonable thing to do regardless of CI issues.

@tuminoid
Copy link
Member

/test-centos-integration-release-1-5

kashifest
kashifest reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2023
@tuminoid
Copy link
Member

/test-centos-integration-release-1-5

@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2024
@metal3-io-bot
Copy link
Collaborator

New changes are detected. LGTM label has been removed.

@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Apr 17, 2024

/est-centos-integration-release-1-6

@Rozzii
Copy link
Member Author

Rozzii commented Apr 17, 2024

/test-centos-integration-release-1-6

dtantsur
dtantsur reviewed Apr 18, 2024
View reviewed changes
vm-setup/roles/libvirt/templates/baremetalvm.xml.j2
<nvram template="/usr/share/OVMF/OVMF_VARS.secboot.fd">/var/lib/libvirt/qemu/nvram/{{ item.name }}.fd</nvram>
{% elif host_os == 'centos' or host_os == 'rhel' %}
<loader readonly='yes' type='pflash'>/usr/share/OVMF/OVMF_VARS.fd</loader>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/VARS/CODE/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On centos it is VARS on ubuntu it is CODE, this is the centos condition

dtantsur
dtantsur reviewed Apr 18, 2024
View reviewed changes
vm-setup/roles/libvirt/templates/baremetalvm.xml.j2
{% else %}
<nvram>/var/lib/libvirt/qemu/nvram/{{ item.name }}.fd</nvram>
<loader readonly='yes' type='pflash'>/usr/share/OVMF/OVMF_CODE.fd</loader>
<nvram template="/usr/share/OVMF/OVMF_CODE.fd">/var/lib/libvirt/qemu/nvram/{{ item.name }}.fd</nvram>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/CODE/VARS/

@Rozzii
use ufei default instead of bios
5a8ccfd 
Apart from recent potential issues related to using bios, uefi
default makes makes more sense in general as for a long time
all enterprise hardware is either using uefi or secure-uefi.

This commit:
  - switched the default libvirt boot loader firmware from bios
    to the more modern uefi

Signed-off-by: Adam Rozman <[email protected]>
@Rozzii
Copy link
Member Author

Rozzii commented May 6, 2024

/metal3-ubuntu-e2e-integration-test-main
/metal3-centos-e2e-integration-test-release-1-7

@Rozzii
Copy link
Member Author

Rozzii commented May 6, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label May 6, 2024
@Rozzii
Copy link
Member Author

Rozzii commented May 6, 2024

/metal3-centos-e2e-integration-test-release-1-7

@Rozzii
Copy link
Member Author

Rozzii commented May 6, 2024

/metal3-ubuntu-e2e-integration-test-main

@Rozzii
Copy link
Member Author

Rozzii commented May 6, 2024

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-release-1-7

@Rozzii Rozzii mentioned this pull request May 8, 2024
Closed
@Rozzii
Copy link
Member Author

Rozzii commented May 13, 2024

/test metal3-ubuntu-e2e-integration-test-main
/test metal3-centos-e2e-integration-test-release-1-7

@Rozzii
Copy link
Member Author

Rozzii commented May 13, 2024

/test metal3-dev-env-integration-test-ubuntu-main

@metal3-io-bot
Copy link
Collaborator

metal3-io-bot commented May 13, 2024 •
edited
Loading

@Rozzii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
metal3-centos-e2e-integration-test-release-1-7 5a8ccfd link true /test metal3-centos-e2e-integration-test-release-1-7

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Rozzii
Copy link
Member Author

Rozzii commented Jun 18, 2024

/test metal3-dev-env-integration-test-ubuntu-main
I am testing prow

@Rozzii
Copy link
Member Author

Rozzii commented Jun 18, 2024

/test metal3-ubuntu-e2e-integration-test-main

@Rozzii
Copy link
Member Author

Rozzii commented Jun 18, 2024

/ok-to-test

@metal3-io-bot metal3-io-bot added the needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. label Jul 31, 2024
@metal3-io-bot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot
Copy link
Collaborator

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 29, 2024
@Rozzii
Copy link
Member Author

Rozzii commented Oct 30, 2024

/remove-lifecycle stale
soon... soon....

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@mquhuy mquhuy mquhuy left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@tuminoid tuminoid tuminoid left review comments

@dtantsur dtantsur dtantsur left review comments

Assignees

@Rozzii Rozzii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates that a PR cannot be merged because it has merge conflicts with HEAD. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Rozzii @tuminoid @metal3-io-bot @dtantsur @mquhuy @lentzi90 @kashifest