Updates flasher to work with the newer firmware interfaces #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coffeefreak101
previously approved these changes
Nov 28, 2023
instead of attempting to match them by vendor, model
…res a powercycle The host power cycle is done if polling the status indicates it's required.
…nect - The bmc helper methods are updated to trace log the bmclib providers attempted for debugging. - The bmclib client is reinitialized if a session gets terminated or the connection was lost because the BMC reset. - Refactor to split out login retry method.
… only when firmware is equal
…ts, rework The poller method is now a generic task status poller, it uses the newer bmclib TaskState consts and will power cycle the host when required. It also returns more useful task status information for debugging.
…are install method
joelrebel
force-pushed
the
dell-redfish
branch
from
6cff991 to
348909d
Compare
|
rebase on main |
- Add Update(), Last() methods on the task Status field
- The poll action method runs while the update is being installed, now
it updates and publishes the task status. So we can have nice things
like
```
{
"ts": "2023-11-29T11:38:53.25051698Z",
"msg": "component: bios, install version: 2.12.4, running step pollInstallStatus -- id: JID_012795319585, state: Downloading, status: Downloading the BIOS_R1VM9_WN64_2.12.4.EXE update package., progress: 0%"
}
```
ofaurax
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do
flasher installPowerStateGet()overredfish,FirmwareInstallStatusovervendorAPI and so on - this would result in various incorrect assumptions about the redfish/vendor API sessions being active.Depends on bmc-toolbox/bmclib#372 and its parents.
Tested on Dells, SMCs X11, X12s.