Adapt to changes needed for gardener-node-agent

[rfranzke]

How to categorize this PR?
/area os
/kind enhancement

What this PR does / why we need it:
This PR adapts this extension to changes needed for gardener-node-agent, see gardener/gardener#8647 for more information.

Which issue(s) this PR fixes:
Part of gardener/gardener#8023

Special notes for your reviewer:
Kindly use the dedicated commits for an easier review process.

/cc @oliver-goetz @majst01 @Gerrit91

Release note:

This extension is now prepared to run with an enabled `UseGardenerNodeAgent` feature gate.

It is assumed that `gardenlet`'s `UseGardenerNodeAgent` is turned on by default if the feature gate is not explicitly set. Hence, make sure to use at least Gardener `v1.82` when using this extension version.

[majst01]

Hi @rfranzke

This is awsome, thanks so much, will take a while til we can test this.

[rfranzke]

Why does the build fail? Running golangci-lint run -p bugs --timeout=3m ./... locally on this branch doesn't yield any findings 👀

[majst01]

Why does the build fail? Running golangci-lint run -p bugs --timeout=3m ./... locally on this branch doesn't yield any findings 👀

It says NewActuator is undefined ?

[rfranzke]

I see this 😄 But all occurrences of NewActuator are fine, even go run and go test work, and local golangci-lint run does not find anything. I'm confused...

[majst01]

I see this 😄 But all occurrences of NewActuator are fine, even go run and go test work, and local golangci-lint run does not find anything. I'm confused...

I check

[majst01]

I updated master with this PR: #34 which compiled nicely, please pull master and it should compile your PR again.

Guess its because the newer linter does not like go-1.20 ??

[rfranzke]

/hold
Let's wait with the merge for another revendoring with gardener/[email protected] containing gardener/gardener#8707

[rfranzke]

/unhold
gardener/[email protected] has been released today, and this PR has been adapted accordingly.

/cc @Gerrit91 @majst01 @oliver-goetz
I think it's ready to be merged now. Please proceed with the review, thank you!

[majst01]

/unhold gardener/[email protected] has been released today, and this PR has been adapted accordingly.

/cc @Gerrit91 @majst01 @oliver-goetz I think it's ready to be merged now. Please proceed with the review, thank you!

Will do, thanks a lot

[oliver-goetz]

nice PR 😄

[Gerrit91]

/ok-to-build

[Gerrit91]

The controller cannot be deployed because the installation helm chart is now broken. 😅

    message: 'chart rendering process failed: render error in "os-metal/templates/deployment.yaml":
      template: os-metal/templates/deployment.yaml:34:52: executing "os-metal/templates/deployment.yaml"
      at <.Values.leaderElection.resourceLock>: nil pointer evaluating interface {}.resourceLock'
    reason: ChartCannotBeRendered

[rfranzke]

The controller cannot be deployed because the installation helm chart is now broken. 😅

Sorry for the delay, this should be fixed now. I've also rebased to master and incorporated the changes from #38 into this PR. Please check again :)

[rfranzke]

Please note, there is one more addition:

It is assumed that gardenlet's UseGardenerNodeAgent is turned on by default if the feature gate is not explicitly set. Hence, make sure to use at least Gardener v1.82 when using this extension version.

[rfranzke]

Later, when this PR is merged, and then even later, after you upgraded to gardener/[email protected] or higher, you can take a look at gardener/gardener-extension-os-gardenlinux#161 for what needs to be done to remove the migration/legacy code.