Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow deploying gardener-extension-shoot-dns-service v1.50.0 #353

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Allow deploying gardener-extension-shoot-dns-service v1.50.0 #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ade5c02
Allow deploying gardener-extension-shoot-dns-service 1.50.0
robertvolkmann Nov 15, 2024
3186161
Fix test
robertvolkmann Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions control-plane/roles/gardener/templates/shoot-dns-service/controller-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ apiVersion: core.gardener.cloud/v1beta1
kind: ControllerDeployment
metadata:
name: extension-shoot-dns-service
type: helm
providerConfig:
chart: "{{ (lookup('url', 'https://raw.githubusercontent.com/' + gardener_shoot_dns_service_repo_ref + '/example/controller-registration.yaml', split_lines=False) | from_yaml_all | list)[0].providerConfig.chart }}"
helm:
rawChart: "{{ (lookup('url', 'https://raw.githubusercontent.com/' + gardener_shoot_dns_service_repo_ref + '/example/controller-registration.yaml', split_lines=False) | from_yaml_all | list)[0].helm.rawChart }}"
values:
image:
repository: "{{ gardener_shoot_dns_service_image_name }}"
Expand Down
10 changes: 4 additions & 6 deletions control-plane/roles/gardener/test/dns_extension_template_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ def test_shoot_dns_extension_controller_deployment_template(self, mock_urlopen):
kind: ControllerDeployment
metadata:
name: extension-shoot-dns-service
type: helm
providerConfig:
chart: a-chart
helm:
rawChart: a-chart
values:
image:
tag: v1.48.0
Expand Down Expand Up @@ -54,9 +53,8 @@ def test_shoot_dns_extension_controller_deployment_template(self, mock_urlopen):
kind: ControllerDeployment
metadata:
name: extension-shoot-dns-service
type: helm
providerConfig:
chart: "a-chart"
helm:
rawChart: "a-chart"
values:
image:
repository: "extension-image"
Expand Down