Create a bgp-neighbor stats and mount result to metal-core #352
Conversation
majst01
force-pushed
the
collect-bgp-neighbor-infos
branch
4 times, most recently
from
8f0fa8e to
61f103a
Compare
majst01
force-pushed
the
collect-bgp-neighbor-infos
branch
from
61f103a to
5c38c3f
Compare
majst01
changed the title
why optional, metal-core will depend on this after the implementation of this feature is finished. |
What is the expected behavior of this feature? What will happen if no BGP state is reported for a port? |
It is reported through metal-api -> metal-metrics-exporter to prevent a switch replace which would loose connectivity to certain machines |
|
Does that mean I can no longer replace a broken switch with a new one? |
You can, its all about visibility in the first place. |
|
So no one is really depending on this feature, and metal-core should be able to function without it. Could you consider making it optional in case we need to disable it in production for any unforeseen reason? |
No, metal-core depends on it with: metal-stack/metal-core#136 Making it optional means more code in metal-core and metalctl, this is a highly useful feature for a stable dataplane and i cannot see any reason why it should not be used. |
|
It is already optional in metal-core. If |
|
This plus the adoption in metal-core are read-only, so no modifications to the switch config are made. |
|
|
||
| /usr/bin/vtysh -c "show ip bgp vrf all neighbors json" > "${tmpfile}" | ||
|
|
||
| rm -f "${destfile}" |
There was a problem hiding this comment.
should be removed, otherwise there might be a short period of time where no file is present
Description
Related to: