Check if INTERFACE needs to be added to config_db in SONiC role #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iljarotar please add a test for this case. |
|
This template is too complicated and error prone. Will try to solve it differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The template for the config_db.json currently has the problem of potentially adding
INTERFACE: nullto the config_db, which ruins all interface configuration. Unfortunately the scoping of jinja2 variables makes it impossible to change a variable value inside of a scope and access the updated value from a different scope (See docs). So I ended up using these complicated chains of filters. Better ideas are welcome.