Implement audit backend for TimescaleDB. #151
Open
+882
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
force-pushed
the
audit-timescaledb
branch
from
e0481fa to
31ebdac
Compare
Gerrit91
force-pushed
the
audit-timescaledb
branch
from
31ebdac to
5c3a30c
Compare
majst01
reviewed
Aug 26, 2024
majst01
reviewed
Jan 24, 2025
Comment on lines
+256
to
+295
| if err := addFilter("body", filter.Body, phrase); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("component", filter.Component, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("detail", filter.Detail, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("error", filter.Error, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("forwardedfor", filter.ForwardedFor, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("path", filter.Path, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("phase", filter.Phase, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("remoteaddr", filter.RemoteAddr, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("rqid", filter.RequestId, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("statuscode", filter.StatusCode, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("tenant", filter.Tenant, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("type", filter.Type, equals); err != nil { | ||
| return nil, err | ||
| } | ||
| if err := addFilter("user", filter.User, equals); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
There was a problem hiding this comment.
this must all match to the Entry json annotations, easy to make mistakes here or miss some of them. There might be a smarter way, but unsure.
Comment on lines
+301
to
+303
| values["from"] = filter.From.UTC() | ||
| where = append(where, "timestamp >= :from") | ||
|
|
There was a problem hiding this comment.
It might be much faster if the where clause against the timestamp is the very first one to reduce the results as early as possible.
There was a problem hiding this comment.
Also timestamp should be indexed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.