use grpc client for wait request (#14)

* use grpc client for wait request
* Use go-hal to detect vendor and set hard coded password for BMC in case of lenovo for now
* use nvm disk for y1 type of machines
* Use metal-stack/go-hal for all BMC and BIOS related calls

Makefile

@@ -7,11 +7,11 @@ MAINMODULE := .
 COMMONDIR := $(or ${COMMONDIR},../builder)
 CGO_ENABLED := 1
 
-in-docker: clean-local-dirs generate-client test all;
+in-docker: clean-local-dirs generate-client gofmt test all;
 
 include $(COMMONDIR)/Makefile.inc
 
-release:: generate-client test all ;
+release:: generate-client gofmt test all ;
 
 .PHONY: clean
 clean::
@@ -93,4 +93,8 @@ qemu-up:
           DEBUG=1  \
           BGP=1" \
 		-kernel metal-hammer-kernel \
-		-initrd metal-hammer-initrd.img.lz4
+		-initrd metal-hammer-initrd.img.lz4
+
+.PHONY: protoc
+protoc:
+	docker run -it --rm -v $(PWD)/../../..:/work metalstack/builder bash -c "cd github.com/metal-stack/metal-hammer && protoc -I cmd -I../../.. --go_out plugins=grpc:cmd cmd/api/v1/*.proto"

cmd/api/v1/wait.proto

@@ -0,0 +1,15 @@
+syntax = "proto3";
+
+package v1;
+
+option go_package = "api/v1";
+
+message WaitRequest {
+    string machineID = 1;
+}
+
+message WaitResponse {}
+
+service Wait {
+    rpc Wait (WaitRequest) returns (stream WaitResponse);
+}

cmd/bios.go

@@ -3,7 +3,6 @@ package cmd
 import (
 	"github.com/metal-stack/metal-hammer/cmd/event"
 	"github.com/metal-stack/metal-hammer/pkg/kernel"
-	"github.com/metal-stack/metal-hammer/pkg/sum"
 	"time"
 
 	log "github.com/inconshreveable/log15"
@@ -12,12 +11,11 @@ import (
 // ConfigureBIOS ensures that UEFI boot is enabled and CSM-support is disabled.
 // It then reboots the machine.
 func (h *Hammer) ConfigureBIOS() error {
-	s, err := sum.New()
-	if err != nil {
-		return err
+	if h.Spec.DevMode || h.Hal.Board().VM {
+		return nil
 	}
 
-	reboot, err := s.ConfigureBIOS()
+	reboot, err := h.Hal.ConfigureBIOS()
 	if err != nil {
 		log.Warn("BIOS updates for this machine type are intentionally not supported, skipping ConfigureBIOS", "error", err)
 		return nil
@@ -39,16 +37,11 @@ func (h *Hammer) ConfigureBIOS() error {
 // EnsureBootOrder ensures that the BIOS boot order is properly set,
 // i.e. first boot from OS image and then PXE boot
 func (h *Hammer) EnsureBootOrder(bootloaderID string) error {
-	if h.Spec.DevMode {
+	if h.Spec.DevMode || h.Hal.Board().VM {
 		return nil
 	}
 
-	s, err := sum.New()
-	if err != nil {
-		return err
-	}
-
-	err = s.EnsureBootOrder(bootloaderID)
+	err := h.Hal.EnsureBootOrder(bootloaderID)
 	if err != nil {
 		return err
 	}

cmd/network/lldpclient.go

@@ -120,11 +120,6 @@ func (l *LLDPClient) requirementsMet() bool {
 			}
 		}
 	}
-	// OK we found 2 distinct chassis mac's
-	if len(neighMap) >= l.Host.minimumNeighbors {
-		return true
-	}
-
-	// Requirements are not met
-	return false
+	// Requirements are met if we found at least 2 distinct chassis mac's
+	return len(neighMap) >= l.Host.minimumNeighbors
 }