make hostname stable, check if sonic is initialized #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0ee0c0b.
…ed vrf names even for route-maps
| return fmt.Errorf("switch is not yet initialized, retrying") | ||
| }, | ||
| retry.Attempts(20), | ||
| retry.Delay(1*time.Second), |
There was a problem hiding this comment.
My gut tells me that twenty seconds may be too low. Maybe one minute?
There was a problem hiding this comment.
DefaultDelayType = CombineDelay(BackOffDelay, RandomDelay)
so the delay basically doubles on every try ... with 20 attempts this would result at the end to a couple of weeks? :-)
# Conflicts: # cmd/internal/switcher/cumulus/cumulus.go # cmd/internal/switcher/templates/applier.go # cmd/internal/switcher/templates/frr.go # cmd/internal/switcher/templates/frr_test.go # cmd/internal/switcher/templates/interfaces.go
This reverts commit f4d9e11.
…ll Nexthop into kernel"" This reverts commit 1086616.
| @@ -40,6 +40,15 @@ func newConfigDB(addr string, id int, separator string) *ConfigDB { | |||
| } | |||
| } | |||
|
|
|||
| func (c *ConfigDB) IsInitialized(ctx context.Context) (bool, error) { | |||
| key := "CONFIG_DB_INITIALIZED" | |||
| result, err := c.rdb.Get(ctx, key).Result() | |||
There was a problem hiding this comment.
Get will return an error of type redis.Nil if the key doesn't exist. We should use Exists.
|
not required anymore since #81 was merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires also to set hostname during metal-core deployment, will be done next.
Fallback is still os.Hostname()
depend on metal-stack/metal-roles#155
TODO: