Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminate the console session if the machine changed #19

Merged
merged 11 commits into from
Sep 9, 2021

Conversation

majst01
Copy link
Contributor

@majst01 majst01 commented Sep 9, 2021

closes #2

Also detects closed console sessions now (for example when someone hits ~. ) and terminates all related resources. This eliminates all errors in the logs seen before.

Tested with metalctl and cloudctl.

Still possible to connect to the same machine with two distinct sessions, but only one will be functional. Solution would be to create either a sts deployment, or store somewhere the connecting client ip per machineID.

Created a issue for this: #20

@majst01 majst01 marked this pull request as ready for review September 9, 2021 10:18
@majst01 majst01 merged commit 73dd107 into master Sep 9, 2021
@majst01 majst01 deleted the terminate-session-if-machine-changed branch September 9, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SSH Session does not die on machine destruction
2 participants